Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(RichTextEditor): add support for blockquotes [WPB-12089] #18557

Merged
merged 9 commits into from
Jan 8, 2025

Conversation

olafsulich
Copy link
Contributor

@olafsulich olafsulich commented Jan 2, 2025

StoryWPB-12089 [Web] Text formatting via UI in text input field

Description

Rich text editor view:
Screenshot 2025-01-02 at 13 14 21

Message view:
Screenshot 2025-01-02 at 13 13 43

Reply to message view:

Screenshot 2025-01-02 at 13 18 49

Multiline + escape:

Screen.Recording.2025-01-07.at.14.19.10.mov

Checklist

  • mentions the JIRA issue in the PR name (Ex. [WPB-XXXX])
  • PR has been self reviewed by the author;
  • Hard-to-understand areas of the code have been commented;
  • If it is a core feature, unit tests have been added;

@codecov-commenter
Copy link

codecov-commenter commented Jan 2, 2025

Codecov Report

Attention: Patch coverage is 29.78723% with 33 lines in your changes missing coverage. Please review.

Project coverage is 46.14%. Comparing base (fa7daf4) to head (032a114).
Report is 3 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev   #18557      +/-   ##
==========================================
- Coverage   46.19%   46.14%   -0.05%     
==========================================
  Files         869      870       +1     
  Lines       26755    26801      +46     
  Branches     6056     6064       +8     
==========================================
+ Hits        12359    12367       +8     
- Misses      12852    12889      +37     
- Partials     1544     1545       +1     

@olafsulich olafsulich marked this pull request as ready for review January 7, 2025 06:29
@olafsulich olafsulich requested review from otto-the-bot and a team as code owners January 7, 2025 06:29
Copy link

sonarqubecloud bot commented Jan 8, 2025

@olafsulich olafsulich merged commit 23f1db1 into dev Jan 8, 2025
16 checks passed
@olafsulich olafsulich deleted the feat/blockquote-preview branch January 8, 2025 08:44
@paulwire paulwire added the echoes: product-roadmap/feature Work contributing to adding a new feature as part of the product roadmap. label Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
echoes: product-roadmap/feature Work contributing to adding a new feature as part of the product roadmap. 👕 size: M type: feature / request ✨
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants